Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce code style ? #80

Closed
PowerKiKi opened this issue Sep 26, 2017 · 1 comment
Closed

Enforce code style ? #80

PowerKiKi opened this issue Sep 26, 2017 · 1 comment

Comments

@PowerKiKi
Copy link
Contributor

Would you accept a PR that use PHP-CS-Fixer and Travis CI to enforce a consistent code style throughout the entire PHP code base ?

I believe this would make it easier to contribute, by avoiding a lots of annoying useless diff (such as trailing whitespaces) and by automating some feedback on incoming PR.

If you agree on the principle, I could suggest PHP-CS-Fixer rules, or you choose them yourself and let me implement the rest via composer and Travis.
@DavidGoodwin
Copy link
Member

Sounds good to me. Please submit a pull request when you are able to.

@PowerKiKi PowerKiKi mentioned this issue Oct 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PowerKiKi @DavidGoodwin