Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clarify PGRST204 error message #3362

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

steve-chavez
Copy link
Member

Closes #3361

@wolfgangwalther
Copy link
Member

This might be technically correct, but is not always an improvement. When your schema cache is up2date, but the column does really not exist... you might be led the wrong way here, assuming you have to reload the schema cache etc.

I'm not saying this change is bad - but it's also not always an improvement. Not sure what to do.

@steve-chavez
Copy link
Member Author

steve-chavez commented Mar 30, 2024

We already have the "schema cache" message in others errors. Which could be misleading in the same way.

"message":"Could not find a relationship between 'car_model_sales_202101' and 'car_models' in the schema cache"} |]

"message":"Could not find the function test.sayhell without parameters in the schema cache",

but it's also not always an improvement. Not sure what to do.

Yeah, but at least being consistent is a bit better.

@steve-chavez steve-chavez marked this pull request as ready for review April 1, 2024 17:55
@steve-chavez steve-chavez merged commit d7c64a9 into PostgREST:main Apr 2, 2024
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Inserts and Updates now require an up-to-date schema cache
2 participants