test: Fix internal_schema_cache_sleep after 747c78f6 #3510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The $subject commit broke internal_schema_cache_sleep for other tests. This reverts the order change, but keeps the scaling by x1000 to ms and thus changes other users of this setting to the new scale.
wolfgangwalther
force-pushed
the
schema-cache-sleep
branch
from
194a4b2
to
f6aae98
Compare
steve-chavez
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The $subject commit broke internal_schema_cache_sleep for other tests. This reverts the order change, but keeps the scaling by x1000 to ms and thus changes other users of this setting to the new scale.
@steve-chavez this should address your valid concerns in #3497 (comment)