Skip to content

Commit

Permalink
uproxx extractor (#66)
Browse files Browse the repository at this point in the history
  • Loading branch information
janetleekim authored and adampash committed Dec 22, 2016
1 parent 87c42b6 commit a20da5e
Show file tree
Hide file tree
Showing 4 changed files with 139 additions and 0 deletions.
4 changes: 4 additions & 0 deletions fixtures/uproxx.com/1481324633976.html

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/extractors/custom/index.js
Expand Up @@ -34,3 +34,4 @@ export * from './people.com';
export * from './www.usmagazine.com';
export * from './www.rollingstone.com';
export * from './247sports.com';
export * from './uproxx.com';
47 changes: 47 additions & 0 deletions src/extractors/custom/uproxx.com/index.js
@@ -0,0 +1,47 @@
export const UproxxComExtractor = {
domain: 'uproxx.com',

title: {
selectors: [
'div.post-top h1',
],
},

author: {
selectors: [
'.post-top .authorname',
],
},

date_published: {
selectors: [
['meta[name="article:published_time"]', 'value'],
],
},

lead_image_url: {
selectors: [
['meta[name="og:image"]', 'value'],
],
},

content: {
selectors: [
'.post-body',
],

// Is there anything in the content you selected that needs transformed
// before it's consumable content? E.g., unusual lazy loaded images
transforms: {
'div.image': 'figure',
'div.image .wp-media-credit': 'figcaption',
},

// Is there anything that is in the result that shouldn't be?
// The clean selectors will remove anything that matches from
// the result
clean: [

],
},
};
87 changes: 87 additions & 0 deletions src/extractors/custom/uproxx.com/index.test.js
@@ -0,0 +1,87 @@
import assert from 'assert';
import fs from 'fs';
import URL from 'url';
import cheerio from 'cheerio';

import Mercury from 'mercury';
import getExtractor from 'extractors/get-extractor';
import { excerptContent } from 'utils/text';

describe('UproxxComExtractor', () => {
describe('initial test case', () => {
let result;
let url;
beforeAll(() => {
url =
'http://uproxx.com/news/rudy-giuliani-not-secretary-of-state/';
const html =
fs.readFileSync('./fixtures/uproxx.com/1481324633976.html');
result =
Mercury.parse(url, html, { fallback: false });
});

it('is selected properly', () => {
// This test should be passing by default.
// It sanity checks that the correct parser
// is being selected for URLs from this domain
const extractor = getExtractor(url);
assert.equal(extractor.domain, URL.parse(url).hostname);
});

it('returns the title', async () => {
// To pass this test, fill out the title selector
// in ./src/extractors/custom/uproxx.com/index.js.
const { title } = await result;

// Update these values with the expected values from
// the article.
assert.equal(title, 'Rudy Giuliani Is No Longer In The Running To Become Donald Trump’s Secretary Of State');
});

it('returns the author', async () => {
// To pass this test, fill out the author selector
// in ./src/extractors/custom/uproxx.com/index.js.
const { author } = await result;

// Update these values with the expected values from
// the article.
assert.equal(author, 'Andrew Husband');
});

it('returns the date_published', async () => {
// To pass this test, fill out the date_published selector
// in ./src/extractors/custom/uproxx.com/index.js.
const { date_published } = await result;

// Update these values with the expected values from
// the article.
assert.equal(date_published, '2016-12-09T22:51:26.000Z');
});

it('returns the lead_image_url', async () => {
// To pass this test, fill out the lead_image_url selector
// in ./src/extractors/custom/uproxx.com/index.js.
const { lead_image_url } = await result;

// Update these values with the expected values from
// the article.
assert.equal(lead_image_url, 'https://uproxx.files.wordpress.com/2016/12/rudy-giuliani-not-secretary-of-state.jpg?quality=90&w=650');
});

it('returns the content', async () => {
// To pass this test, fill out the content selector
// in ./src/extractors/custom/uproxx.com/index.js.
// You may also want to make use of the clean and transform
// options.
const { content } = await result;

const $ = cheerio.load(content || '');

const first13 = excerptContent($('*').first().text(), 13);

// Update these values with the expected values from
// the article.
assert.equal(first13, 'Getty Image Longtime Donald Trump advocate Rudy Giuliani has reportedly removed himself from');
});
});
});

0 comments on commit a20da5e

Please sign in to comment.