Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'folderStrategy' option does nothing #169

Closed
schneivo77 opened this issue Feb 28, 2020 · 2 comments
Closed

'folderStrategy' option does nothing #169

schneivo77 opened this issue Feb 28, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@schneivo77
Copy link

Hi,

I looked into lib/options.js to find out which options exist beside those mentioned in the docs and saw the folderStrategy option:

{
	name: 'Set folder strategy',
	id: 'folderStrategy',
	type: 'enum',
	default: 'paths',
	availableOptions: ['paths', 'tags'],
	description: 'Determines whether the importer should attempt to create the folders according' +
	 'to paths or tags which are given in the spec.',
	external: true
},

But at the moment this option does nothing.
Is it not implemented yet or did you forget to do so? Because in the branch adding_support_for_tags_folders the feature was already implemented, wasn't it?

@abhijitkane
Copy link
Member

@schneivo77 Apologies - this option was incorrectly merged. We're removing this for now, and working on completing the actual feature branch.

@abhijitkane abhijitkane added the bug Something isn't working label Apr 27, 2020
@umeshp7 umeshp7 closed this as completed Apr 28, 2020
@umeshp7
Copy link
Member

umeshp7 commented Apr 28, 2020

Fixed in #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants