New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: named view support #6
Conversation
I fixed the errors on windows, you can rebase @hannoeru |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! I just found a few bugs I introduced myself early on and I going to refactor a little bit the splitting of the path after merging
@@ -63,8 +63,10 @@ export function createRoutesContext(options: Required<Options>) { | |||
|
|||
function addPage(path: string) { | |||
log('added', path) | |||
const route = stripRouteFolder(path) | |||
// TODO: handle top level named view HMR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what did you mean with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't dig into it yet, but currently named view has some bug with HMR when you change routes's filename.
No description provided.