feat: catch resolve errors (fixes #41) #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2 #53 +/- ##
=======================================
Coverage 99.01% 99.02%
=======================================
Files 5 5
Lines 102 103 +1
Branches 11 11
=======================================
+ Hits 101 102 +1
Misses 1 1
Continue to review full report at Codecov.
|
Adds a try/catch around the route resolution to simplify testing scenarios where the developers use `router.push({name: 'hey'})` and do not want to declare the corresponding route, as they just want to check if `push` was called.
Fixes posva#41
posva
force-pushed
the
fix/41-catch-resolve-error
branch
from
6d59048
to
ee1efd6
Compare
posva
approved these changes
Mar 30, 2021
|
Sounds good. I like that the default is the more permissive way, thanks for merging this 👍 |
|
Thanks for the proposal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Adds a try/catch around the route resolution to simplify testing scenarios where the developers use
router.push({name: 'hey'})and do not want to declare the corresponding route, as they just want to check ifpushwas called.Fixes #41