Convert gesture recognizer to use only discrete states and fix bug that occurs when dragging while reloading #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does look very good. I appreciate all the work you did. I indeed rushed the code on the state handling and your code seems much cleaner. I need to get out for about an hour, when I'll ge back, I'll test the PR on my end and merge it if everything works fine. Thank you very much |
|
No prob. Using gesture recognizers for this is a great idea btw. Didn't mean for that last rewrite commit to sneak on here. I'm going to try to move it to a "development" branch so it doesn't get caught up in this pull request. |
pier-oliviert
added a commit
that referenced
this pull request
Feb 17, 2012
Convert gesture recognizer to use only discrete states and fix bug that occurs when dragging while reloading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Noticed a bug: when the recognizer is in its loading state, dragging the table view will trigger another simultaneous reload. The gesture recognizer should fail when a load is in progress.
While fixing this I cleaned up the touch handling, converting it to use only states reserved for discrete recognizers instead of its oddball discrete/continuous hybrid set of states used previously.
Cheers!