Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow secrets.yml to be an Environment variable instead #163

Closed
pier-oliviert opened this issue Aug 7, 2016 · 0 comments
Closed

Allow secrets.yml to be an Environment variable instead #163

pier-oliviert opened this issue Aug 7, 2016 · 0 comments

Comments

@pier-oliviert
Copy link
Owner

I'm thinking that Ecrire's configuration could also be set through an environment variable. This would be useful for testing and docker setups.

I'm thinking to have ecrire look for secrets.yml first, then if it's not set would fallback to the environment variable ECRIRE_SECRETS which would be a JSON encoded string.

This would have the advantage of being simple to setup and also to set different setting under a single environment variable.
pier-oliviert added a commit that referenced this issue Aug 12, 2016
@pier-oliviert
Secrets can now be set through environment variable
8e4a4d0 
Also modified the way the initialization works. Instead of relying on
some arbitrary data, a flag must be set in secrets.yml which dictactes
if the app is in onboarding mode.

Fix #163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pier-oliviert