-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for updates #14
Comments
This is my first time dealing with this type of problem, but I would like to give it a try.
What do you think? P.S. |
From reading the Github API documentation, it appears that unauthenticated requests from the same IP are limited to 60 per hour.
If we implement this feature without the flag, users may end up consuming a number of API requests on github every time they run tcping. Is there any good way to do this? |
Hi, Your thought process looks fine to me as well. I am not really familiar with I also contacted you through the email you provided (and removed the email from your comment for privacy reasons). |
That is a very valid concern. Let's not automatically do it by default. |
Based on the discussion here, this issue can be ruled out in favor of #15 |
Hi.
Thank you for your opinion!
I see.
Yes, I think too. But, I don't have any ideas at the moment. First, when I implement the update message is displayed without flag, I will put out a PR. |
perfect! |
Summary
TCPING is constantly being worked on and updated. Our users could benefit from these features.
We need to check for updates upon running the program and display a message if there is a newer version.
Important Notes
This should not cause
tcping
to get flagged as a malicious program onWindows
. If we see this is the case but the benefits of checking for a newer versions exceeds the inconvenience, we might end up splitting theWindows
version or to just make it an optional flag.The text was updated successfully, but these errors were encountered: