Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config parameters should be moved out into a config file #9

Closed
shashaBot opened this issue Mar 26, 2020 · 2 comments · Fixed by #15
Closed

Config parameters should be moved out into a config file #9

shashaBot opened this issue Mar 26, 2020 · 2 comments · Fixed by #15
Assignees
@BhavyaC16
Labels
good first issue Good for newcomers

Comments

@shashaBot
Copy link
Collaborator

Currently, the firebase parameters are present in the js code. We should move them out to a config file and load from there.
@shashaBot shashaBot added the good first issue Good for newcomers label Mar 26, 2020
@shashaBot shashaBot changed the title Config parameters should be moved out of the code Config parameters should be moved out into a config file Mar 28, 2020
@BhavyaC16
Copy link
Contributor

Hi! I am interested in working on this issue. Can I please take it up?

@BhavyaC16 BhavyaC16 mentioned this issue Apr 6, 2020
Merged
@BhavyaC16
Copy link
Contributor

Hi, I have opened a pull request for this issue. Looking forward to your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BhavyaC16 BhavyaC16

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Shift firebase config parameters to config file BhavyaC16/LatexGo
2 participants
@shashaBot @BhavyaC16