Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor Contrast Entering Text via User Snippet #29

Closed
jasonjohnson47 opened this issue Dec 18, 2018 · 3 comments
Closed

Poor Contrast Entering Text via User Snippet #29

jasonjohnson47 opened this issue Dec 18, 2018 · 3 comments
Assignees

Comments

@jasonjohnson47
Copy link

First, compliments on the theme. It's by far my favorite. Thank you for creating it and all your effort!

In the light theme, when inserting HTML (or CSS) via a user snippet and then typing into the tabstop via the $1 in the html.json or css.json file, the contrast between the highlight background color and foreground text color is poor, especially for comments. See attached screenshot.

editor-comment-example

@pouyakary
Copy link
Owner

Hi! thank for using Pro Colors and your kind words! I didn’t know this thing existed and honestly have no I idea where does that highlight color comes form. I will try to recreate the incident, but since the definition of Pro Colors does not have any color that even looks like that background, I believe that is due to colorization of an extension. So while I try to see if that happens in my machine as well, please test this in an environment with your extentions disabled to trace the origin

@jasonjohnson47
Copy link
Author

Thank you for looking into it! I believe that is all built-in features and functionality of VS Code. See the documentation here:
https://code.visualstudio.com/docs/editor/userdefinedsnippets#_creating-your-own-snippets
and
https://code.visualstudio.com/docs/editor/userdefinedsnippets#_tabstops

@pouyakary
Copy link
Owner

@jasonjohnson47 so I checked it out and yeah you're right it seems that my definitions for snippets were damaged, so I added some new ones. In the next release this is fixed.

@pouyakary pouyakary self-assigned this Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants