Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.0 still renders version 2.5 #162

Closed
leonardfischer opened this issue Aug 18, 2022 · 8 comments
Closed

Version 3.0 still renders version 2.5 #162

leonardfischer opened this issue Aug 18, 2022 · 8 comments

Comments

@leonardfischer
Copy link

Hello,

when running version 3.0 of the magic number detection it still runs with this output

phpmnd version 2.5.0 by Povilas Susinskas

public const VERSION = '2.5.0';

@sidz
Copy link
Collaborator

sidz commented Aug 18, 2022

Thanks for report this issue. But I can't do anything due to lack of reviewers.

TBH I decided to write a couple phpstan rules instead of using phpmnd.

p.s. I'm happy to create PR in case anybody review them :)

@maks-rafalko
Copy link

TBH I decided to write a couple phpstan rules instead of using phpmnd.

Please, make sure to share them if they will be finished one day ;)

@maks-rafalko
Copy link

p.s. I'm happy to create PR in case anybody review them :)

@exussum12 could you please help here?

@exussum12
Copy link
Collaborator

Added a PR if you could approve @sidz #163

@sidz
Copy link
Collaborator

sidz commented Aug 18, 2022

it would be nice to update CHANGELOG.md. Unfortunately I don't have access to do it in master so it is possible only within new PR

@exussum12
Copy link
Collaborator

Added the changelog to the PR too

@leonardfischer
Copy link
Author

Thank you for looking into this :) It was quite confusing when reading logs from our CI server

@sidz
Copy link
Collaborator

sidz commented Aug 19, 2022

released https://github.com/povils/phpmnd/releases/tag/v3.0.1

thanks @leonardfischer

@sidz sidz closed this as completed Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants