Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support do ... end block in view helper #151

Open
danschultzer opened this issue Feb 24, 2020 · 0 comments · May be fixed by #153
Open

Support do ... end block in view helper #151

danschultzer opened this issue Feb 24, 2020 · 0 comments · May be fixed by #153
Labels
enhancement New feature or request

Comments

@danschultzer
Copy link
Collaborator

Prompted on the slack channel:

Any hint how to change the providers label to an icon in Pow Assent? Do I have to write my self the tag information without the default text?

It would be great if we could inject a tag instead of the text that way it would be great to replace the text

The view helper is really simple, but it make sense to me if you could pass a do ... end block the same way as if it was just a link:

PowAssent.Phoenix.provider_links @conn, do
  tag(:span, provider, ...)
end
@danschultzer danschultzer added the enhancement New feature or request label Feb 24, 2020
@danschultzer danschultzer linked a pull request Mar 14, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant