Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reserved Instance Pricing Support #124

Merged
merged 3 commits into from Aug 25, 2015

Conversation

serpentblade
Copy link
Contributor

Updated the build process to fetch and parse reserved instance data.
Added 4 new columns for reserved instance costs
Added filter for reserved terms pricing (1/3yr, Amount paid upfront)

Thoughts before merging however:
The data I'm pulling for reserved instances is the "effective" hourly rate, which is Amazon's calculated based on upfront payment spread over every hour of the contract terms. So, actual hourly rate is lower, but has that unclear upfront cost. Should there be some indication of how this value is calculated, or a separate column for upfront cost?

@powdahound
Copy link
Contributor

Perhaps a tooltip on the column would work? The "Compute Units" column does this to provide a clearer description.

@serpentblade
Copy link
Contributor Author

Tapping into my profound ability to write content, I came up with:

Reserved costs are an "effective" hourly rate, calculated by hourly rate + (upfront cost / hours in reserved term). Actual hourly rates may vary.

Updated my commits. Perhaps that'll be good enough? Didn't want to mislead/confuse people if at all possible

@serpentblade
Copy link
Contributor Author

Hate to bump, but was wondering if there's anything I can do or you'd like adjusted for this PR.

@powdahound
Copy link
Contributor

Appreciate the bump, since I lost track of this. Will make some time this weekend to go through the open PRs and merge things in.

powdahound added a commit that referenced this pull request Aug 25, 2015
Add Reserved Instance Pricing Support
@powdahound powdahound merged commit b50d689 into vantage-sh:master Aug 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants