Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_gist doesn't handle redirects #93

Closed
styrmis opened this issue Jan 31, 2014 · 1 comment · Fixed by #96
Closed

get_gist doesn't handle redirects #93

styrmis opened this issue Jan 31, 2014 · 1 comment · Fixed by #96

Comments

@styrmis
Copy link

styrmis commented Jan 31, 2014

get_gist doesn't handle redirects, which leads to examples of the following being downloaded and installed e.g. in config/initializers/rdebug.rb:

<html><body>You are being <a href="https://gist.github.com/csiszarattila/1135055/raw">redirected</a>.</body></html>

This was fixed once before by replacing the gist URLs but even after that, powder debug still fails to install the initialiser as gists are now being redirected to another URL within the gist owner's account.

Rather than patching the URLs which can break whenever Github changes the addresses, perhaps it would be better to extend get_gist so that it follows redirects.

I'll try to submit a pull request for this today.
@styrmis styrmis mentioned this issue Jan 31, 2014
Closed
This was referenced Feb 1, 2014
Merged
Merged
@thomasklemm
Copy link
Collaborator

See #94 and #96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update gist urls powder-rb/powder
2 participants
@styrmis @thomasklemm