Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple permutations into a VM are generated incorrectly #1384

Open
pacheco opened this issue May 17, 2024 · 1 comment
Open

Multiple permutations into a VM are generated incorrectly #1384

pacheco opened this issue May 17, 2024 · 1 comment
Labels
bug Something isn't working codegen compiler

Comments

@pacheco
Copy link
Collaborator

pacheco commented May 17, 2024

Currently, linking into a VM submachine with more than two permutations generates the wrong constraints.
As an example, the following permutations are generated for a simple case with two operations (add/sub):

main.instr_add { 2, main.X, main.Y, main.Z } is main_arith.instr_return { main_arith._operation_id, main_arith._input_0, main_arith._input_1, main_arith._output_0 };
main.instr_sub { 4, main.X, main.Y, main.Z } is main_arith.instr_return { main_arith._operation_id, main_arith._input_0, main_arith._input_1, main_arith._output_0 };

RHS selector needs to be unique for the valid rows of each operation.

@pacheco
Copy link
Collaborator Author

pacheco commented May 17, 2024

maybe we can use a single permutation per caller machine, the discussion in these issues might be useful #1077 #1073

@leonardoalt leonardoalt added bug Something isn't working compiler codegen labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working codegen compiler
Projects
None yet
Development

No branches or pull requests

2 participants