Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: rows/finalizabledata: do finalize and transpose in one pass #1523

Open
chriseth opened this issue Jul 2, 2024 · 0 comments
Open

Comments

@chriseth
Copy link
Member

chriseth commented Jul 2, 2024

In the block and VM machine we have rows of cells that are writable. At some point their range constraints are deleted and only the value is stored (together with a flag to denote that the value is known). This process is called "finalization". At the end of witgen, the values are then stored into column vectors (while we had rows before), which is called transposition.

There is probably no real need for storing finalized rows and we could just do transposition at the point of finalization. We could do it less often than finalization to reduce the impact of memory cache misses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant