Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update django-ipware, Test with Github Actions #14

Closed
wants to merge 2 commits into from

Conversation

mjnaderi
Copy link
Contributor

Hi,

This PR fixes #11. Plus I re-structured tests and added Github Actions for running tests against Python 3.6-3.9 and Django 1.11-3.1.

@cnelson
Copy link

cnelson commented Oct 11, 2021

@bartdag any chance of getting this merged? ipware has is up to 4.x now, pinning this lib to such an old version makes it hard to use :(

@jonathanmach
Copy link
Contributor

Is this project still being mantained?

@mikicz
Copy link

mikicz commented Oct 23, 2021

It doesn't seem like this repo is being maintained so a while back I forked it and now I maintain a fork at https://github.com/mikicz/pytracking released to https://pypi.org/project/pytracking2/

@jonathanmach
Copy link
Contributor

It doesn't seem like this repo is being maintained so a while back I forked it and now I maintain a fork at https://github.com/mikicz/pytracking released to https://pypi.org/project/pytracking2/

That's helpful, thanks @mikicz !

@bartdag
Copy link
Member

bartdag commented Oct 23, 2021

working on it right now ;-p

bartdag added a commit that referenced this pull request Oct 23, 2021
…and remove unsupposed Django except 1.11.
bartdag pushed a commit that referenced this pull request Oct 23, 2021
bartdag added a commit that referenced this pull request Oct 23, 2021
bartdag added a commit that referenced this pull request Oct 23, 2021
@bartdag
Copy link
Member

bartdag commented Oct 23, 2021

Thank you @mjnaderi . Almost a year later, we merged your wonderful contribution! We'll try to publish on pypi soon.

@bartdag bartdag closed this Oct 23, 2021
@bartdag
Copy link
Member

bartdag commented Oct 23, 2021

Deployed on pypi: https://pypi.org/project/pytracking/

@jonathanmach
Copy link
Contributor

Great stuff @bartdag! Very much appreciated!

@mjnaderi
Copy link
Contributor Author

@bartdag Thanks for merging. 🎉 Now we can use the original package instead of our fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package breaks with django-ipware>=3
5 participants