Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hotreload when template, configuration file is changed #150

Closed
lukasmrtvy opened this issue Oct 21, 2021 · 4 comments
Closed

feat: hotreload when template, configuration file is changed #150

lukasmrtvy opened this issue Oct 21, 2021 · 4 comments

Comments

@lukasmrtvy
Copy link

lukasmrtvy commented Oct 21, 2021

would be great to implement support for hotreload ( if it is explicitily allowed via ENV variable for example ) application when template, configuration file is changed

reference: https://github.com/weaveworks/Watch

also notifications support would be deal to this feature ( send webhook after hotreload )

reference https://github.com/containrrr/shoutrrr

thanks

@powerman
Copy link
Owner

Hotreload of what? dockerize is mostly used as a shortly running command, and even if it runs for a long time (like in "tail" mode) I don't see which sort of configs might change to affect how "tail" works.

It sounds like you want tool to reload your services if their configuration changes, but such tools are already available and you can run them by dockerize - what's the point in embedding functionality of these tools into dockerize?

@lukasmrtvy
Copy link
Author

maybe i misunderstand dockerize`s use case, its not supervisor like confd, right?

@powerman
Copy link
Owner

Not really. It's just a helper to run apps in a docker, solving usual issues related to containers, like:

  • needs to wait until required services (like MySQL) starts in another containers before running the app
  • needs to copy environment variable values into app's config before starting the app
  • needs to stream app's log file to stderr

I.e. dockerize takes the app which wasn't designed for use in containers and makes it easier to use it in containers. In 99% cases dockerize won't even continue to runs after starting the app.

@lukasmrtvy
Copy link
Author

lukasmrtvy commented Oct 27, 2021

okey, thanks, can You suggest a service that can handle hotreloads ? watch by weave, or watchman by facebook ?

EDIT:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants