Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checksum should reference the artifact #43

Closed
micheelengronne opened this issue May 19, 2020 · 1 comment
Closed

checksum should reference the artifact #43

micheelengronne opened this issue May 19, 2020 · 1 comment

Comments

@micheelengronne
Copy link

Currently the checksum file does contain the checksum but instead of the artifact filename it contains a -.

In order for the checksum file to work, it should reference the artifact filename. For instance, with gitea: https://github.com/go-gitea/gitea/releases/download/v1.12.0-rc1/gitea-1.12.0-rc1-darwin-10.6-386.sha256

@powerman
Copy link
Owner

Well, it was there few commits before, but I've removed it intentionally. Thing is, usually only one of binaries is downloaded, and then it's renamed to just dockerize. This means name hardcoded in .sha256 file won't match downloaded file name and thus check will fail. README contains example how to handle current files.

Feel free to reopen if you belive I'm wrong about this and have use case which require file names in .sha256 files and also have solution for use case mentioned above (single file download as per README install instructions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants