Not working properly with JUnit 4.10+

[johanhaleby]

From diego.co...@gmail.com on February 02, 2012 22:20:41

What steps will reproduce the problem? 1. Use JUnit 4.10+ What is the expected output? What do you see instead? The constructor of PowerMockRunner is using a method getJUnitVersion() that is return 4.1 for a JUnit 4.10+ and always returning false to condition ( getJUnitVersion() >= 4.7f ). so, i think it is executing wrong impl PowerMockJUnit44RunnerDelegateImpl instead of PowerMockJUnit47RunnerDelegateImpl What version of the product are you using? On what operating system? Win 7, 64 bits, JDK 7U2, compiling with 6.. and powermock-mockito-1.4.11-full Please provide any additional information below.

Original issue: http://code.google.com/p/powermock/issues/detail?id=367

[johanhaleby]

From johan.ha...@gmail.com on February 03, 2012 01:11:41

Thanks for reporting. Could you create a patch for this? I think it should be relatively simple to fix.

Status: Accepted

[johanhaleby]

From diego.co...@gmail.com on February 03, 2012 03:44:00

I can try it tomorrow.. on saturday.

[johanhaleby]

From johan.ha...@gmail.com on February 03, 2012 03:51:01

Thank you very much.

[johanhaleby]

From diego.co...@gmail.com on February 04, 2012 07:00:13

Here is a patch, i did a class to hold principal version and major to compare when necessary, i tried to create some tests but i had problems with CGLib, im trying to repair... if you need any modification just tell me and ill try to help.

PS: I did the versioncompatibility class in project powermock-module-junit4-common

Attachment: PowerMockRunner.java.patch VersionCompatibility.java.patch

[johanhaleby]

From johan.ha...@gmail.com on February 06, 2012 00:01:13

Thanks for the patch. I've applied it (I think you created the patch for something else than the latest version though?) but for I can't seem to push right now because of 502 Bad Gateway. Will try again later.

[johanhaleby]

From johan.ha...@gmail.com on February 06, 2012 00:02:55

Btw, I created some tests as well and it works.

[johanhaleby]

From johan.ha...@gmail.com on February 07, 2012 02:26:21

Status: Fixed