Improve Task usage #1172
Merged
Improve Task usage #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
commented
Jan 30, 2020
| @@ -639,267 +639,262 @@ public Task<RunspaceHandle> GetRunspaceHandleAsync(CancellationToken cancellatio | |||
| errorMessages, | |||
| executionOptions)).ConfigureAwait(false); | |||
| } | |||
| else | |||
|
|
|||
There was a problem hiding this comment.
If you hide whitespace changes here, you'll see I just got rid of the else. Been wanting to do that for a while.
src/PowerShellEditorServices/Services/PowerShellContext/PowerShellContextService.cs
Outdated
Show resolved
Hide resolved
TylerLeonhardt
approved these changes
Jan 30, 2020
SeeminglyScience
approved these changes
Jan 31, 2020
| RunWriter, | ||
| CancellationToken.None, // Inner method will manage cancellation | ||
| TaskCreationOptions.LongRunning | TaskCreationOptions.DenyChildAttach, | ||
| TaskScheduler.Default); |
There was a problem hiding this comment.
If this never exits, I'd just throw it in a Thread like you mentioned.
…hellContextService.cs Co-Authored-By: Tyler James Leonhardt <tylerl0706@gmail.com>
|
Issues
======
+ Solved 3
See the complete overview on Codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the following changes:
Task.Factory.StartNewinvocations toTask.Runto simplify the child attach semantics (invoking tasks won't hang around for new threads to finish now, since in the places where we use it, it seems we really wanted to kick off a new thread)async/awaitfrom methods that just do some setup and run another taskTaskOptions.LongRunninghint to the logger thread so that it's less likely to impact the thread pool. The other option here is to use a newThreadand bypass the thread pool altogether. Happy to do either (but this one represents a smaller change).