switch to string.empty #1174
Merged
switch to string.empty #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
reviewed
Jan 31, 2020
| @@ -312,7 +312,7 @@ public void SendControlC() | |||
| keyValuePair.Key, | |||
| keyValuePair.Value != null | |||
| ? PSObject.AsPSObject(keyValuePair.Value) | |||
| : null); | |||
| : string.Empty); | |||
There was a problem hiding this comment.
Maybe the comment is wrong "Convert all values to PSObjects" but if not, maybe this should be:
psObjectDict.Add(
keyValuePair.Key,
PSObject.AsPSObject(keyValuePair.Value ?? string.Empty));
There was a problem hiding this comment.
yours is nicer 😄 went with that.
rkeithhill
approved these changes
Jan 31, 2020
rjmholt
approved these changes
Jan 31, 2020
SeeminglyScience
approved these changes
Feb 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes PowerShell/vscode-powershell#1790
Changes the default to
string.Emptyto be constant with ConsoleHost.This also means that
Read-HostandRead-Host -Prompthave the same behavior when the user just hits<ENTER>on a prompt.