Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI Player goes out of tune #361

Closed
BigHonkinDaddy opened this issue Jan 9, 2022 · 1 comment
Closed

MIDI Player goes out of tune #361

BigHonkinDaddy opened this issue Jan 9, 2022 · 1 comment

Comments

@BigHonkinDaddy
Copy link

Sometimes, after pausing, repositioning and restarting the midi player, its out of tune, sometimes a step higher, sometimes a step lower. When this happens, the midi player remains out of tune until encountering a bend or slide at then adjusts itself back to the proper tuning.

To Reproduce
I will attempt to reproduce the behavior in a sample file and upload. More to come....

Version
Windows 10, Alpha 16.

@cameronwhite
Copy link
Member

MidiOutputDevice::stopAllNotes() should probably also reset the pitch wheel
Or, maybe MidiFile::load should also reset the pitch wheel at the same time as it sets the pitch bend range

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants