Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morph translation #41

Closed
StrangerGithuber opened this issue Nov 4, 2016 · 7 comments
Closed

Morph translation #41

StrangerGithuber opened this issue Nov 4, 2016 · 7 comments

Comments

@StrangerGithuber
Copy link

Hello
First of all, thank you your updates. You save my life. :)
Can you add a function which help to translate Morph japanese names to english?
"Rename bones to english" very handy so I though Morph translate also will be good.

(I wanted to add this in "Pull requests" but its appears on another developer site so I write here in Issues. I hope its appear here not there.)

@ptrthomas
Copy link

I think the "other developer" you are referring to is me ^_^

In fact I want to translate the material names also (which is useful especially when you export to other apps like Unreal Engine). I was planning to do this so let me look at morph names also.

@ptrthomas
Copy link

@LeaderSoul oh I see it now, you made a pull request on the original project by @sugiany . I am not the dev here - it is @powroupi - but I was involved in the english translation code.

@powroupi
Copy link
Owner

powroupi commented Nov 5, 2016

@LeaderSoul If you didn't intend to make the pull request sugiany#55, you might need to close it. (I guess you just wanted to make a feature request) :)

About "Morph translate", currently i don't have any good idea to implement it, and it's a little complex to integrate to "Morph Tools", sorry. 😢 Maybe @ptrthomas or other developers could help this, and i might try to implement it as well once i got any good idea. Thank you. 😄

@ptrthomas
Copy link

@powroupi I was looking at the code - and yes, it seems complex. I was thinking if we just fill the morph_name_e - would that help users who just want a translation. Or maybe, we just need a tooltip to show the translated name. Or something similar.

@powroupi
Copy link
Owner

powroupi commented Nov 5, 2016

@ptrthomas I was thinking if we just fill the morph_name_e - would that help users who just want a translation.

Yeah, it is much easier to do and maybe just add a import option or operator, say "Fill English Names", and then fill all .name_e stuff if the string is empty. :) But i think we still need a tool (or a rule) to update corresponding blender's name properties (shape key names, material names, etc.). 🤔

@lordscales91
Copy link

I don't how much the code changed since the last time I checked, but I think we could also add a property to VertexMorph to store the reference to the shape key (sk_name for example). That way the names of the shape keys can be in English, which is probably what @LeaderSoul wants. (Of course this will require more changes in other parts of the code that reference the shape keys)

@StrangerGithuber
Copy link
Author

Specifically:
Can you add a new option in import part which is helps translate automatically the morphs name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants