Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slurm computation manager: improve unit test coverage #19

Open
sylvlecl opened this issue Sep 30, 2019 · 0 comments
Open

Slurm computation manager: improve unit test coverage #19

sylvlecl opened this issue Sep 30, 2019 · 0 comments

Comments

@sylvlecl
Copy link
Contributor

  • Do you want to request a feature or report a bug?

Quality improvement.

  • What is the current behavior?

The slurm computation manager has integration tests, but the pure unit tests could cover a larger part of the code.

  • What is the expected behavior?

We could increase the coverage on some parts:

  • flag files monitor

  • scontrol monitor

  • general task management behaviour (cancels etc.)
    This will require to mock some inner used components (file system, command runner), and maybe to design another inner interface which would encapsulate closely the interactions with slurm.

  • What is the motivation / use case for changing the behavior?

Robustness, and "auto-documentation".
For example, the flag files monitor behaviour could be illustrated with simple unit tests.

  • Please tell us about your environment:
    • PowSyBl Version: ...
    • OS Version: ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant