Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPYNB has issues #18

Closed
tlienart opened this issue Nov 12, 2018 · 3 comments
Closed

IPYNB has issues #18

tlienart opened this issue Nov 12, 2018 · 3 comments

Comments

@tlienart
Copy link
Contributor

tlienart commented Nov 12, 2018

When going through the notebook, there were several issues, some I could fix, some I could not.

  1. use of pipeline is now prohibited (clashes with Base)
  2. the RandomForest should have :num_subfeatures => 0 and not => nothing afaiu
  3. I could not run the Scikitlearn cell note that both *_AVAILABLE bools are false (maybe I didn't do something but couldn't find different way)
julia> CombineML.System.LIB_SKL_AVAILABLE
false
julia> CombineML.System.LIB_CRT_AVAILABLE
false

and so SKLLearner was not available.

  1. use of mean must now be accompanied by using Statistics
  2. I could not run @parallel, I'm assuming it comes from using Distributed but may have changed name

The fixes on the notebook: https://github.com/tlienart/CombineML.jl , now in a PR fixing (1, 2, 4) #19

@ppalmes
Copy link
Owner

ppalmes commented Nov 12, 2018

Thanks for pointing this out. Yes, I forgot to update the notebook. I'll update it this week including your changes. Maybe you can create a pull request?

@tlienart
Copy link
Contributor Author

👍 the reason I had not was because I couldn't fix all the issues, also git modifs on notebooks are a pain but I've now opened one with the current fixes for (1, 2, 4) #19

@ppalmes
Copy link
Owner

ppalmes commented Mar 4, 2019

this notebook has been rewritten to reflect the API changes.

@ppalmes ppalmes closed this as completed Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants