Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting by NULL LAST #267

Closed
jhrncar opened this issue Jul 12, 2022 · 3 comments · Fixed by #296
Closed

Sorting by NULL LAST #267

jhrncar opened this issue Jul 12, 2022 · 3 comments · Fixed by #296
Labels
enhancement New feature or request released will accept PR

Comments

@jhrncar
Copy link

jhrncar commented Jul 12, 2022

Hello,

Correct me if I am wrong, but there is currently no way to define in sortableColumns config, that null records should be sorting as last and not first.

image
image

If anyone has any workaround, feel free to correct me <3

Thanks!
@ppetzold
Copy link
Owner

https://chiayupai.medium.com/typeorm-orderby-nulls-last-w-mysql-4e35af85fe2

Happy to accept PR :)

@ppetzold ppetzold added enhancement New feature or request will accept PR labels Jul 28, 2022
@Elbarae1921 Elbarae1921 mentioned this issue Aug 20, 2022
Merged
@Elbarae1921
Copy link
Contributor

Seeing as how there hasn't been much activity on this, I took the liberty of submitting a PR #296.

@ppetzold
Copy link
Owner

🎉 This issue has been resolved in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released will accept PR
Projects
None yet
Milestone
No milestone
3 participants
@ppetzold @Elbarae1921 @jhrncar