EqualsMatcher does not work for String.class

[skrilagg]

Hi,

after I finished working on SaveSamples-part of a service execution, I started with the LoadSamples-part.
This quickly throw me an Matcher-Error for a call like Sample.of(service.doStuff(Matchers.equalTo("MyString"))); as the EqualsMatcher does not allow a type without an equals-implementation.

As a workaround I then used Matcher.matcher(param -> "MyString".equals(param)).

When taking a look at e.g. hamcrest as matcher library, this is working with String as well.
I thought about implementing a hamcrest-to-ParameterMatcher wrapper but wanted to let you know first as you maybe want to do something about this inside deepsampler.

Best regards,
Michel Pittelkow

[JanSchankin]

Hi Michel,

unfortunatly, I was unable to reproduce this, yet. Could you provide us with a StackTrace or a running example, maybe even a short TestCase?

In theory DeepSampler should be able to use Strings in Matchers::equalTo(...). It is even the default Matcher, so you could just write

Sample.of(service.doStuff("MyString"));

There are some running tests that show the usage of Strings with equalTo():

First, the implicit version without writing Matchers.equalTo(...):

deep-sampler/deepsampler-provider/src/testFixtures/java/de/ppi/deepsampler/provider/common/SamplerAspectTest.java

Line 93 in 109f637

public void singleArgumentValueMatchesAndSampleIsChanged() {

And then the explicit version using Matchers.equalTo(...) (well, I used a static import here, so it's just equalTo(...) in this case):

deep-sampler/deepsampler-provider/src/testFixtures/java/de/ppi/deepsampler/provider/common/SamplerAspectTest.java

Line 282 in 109f637

public void samplesCanUseAMixedCombinationOfMatchers() {

Is this what is throwing Execptions in your case, or am I on the wrong track?

Greetings
Jan

[skrilagg]

Hi Jan,

I just tried to reproduce this error once more, but without success. I'll close this issue, sorry for any inconveniences caused.

Best regards
Michel

[JanSchankin]

Hi Michel,
no problem, issue reports and suggestions for improvements are always welcome!
Greetings
Jan