Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Przełączenie się na Webpacka, przeniesienie szablonów admina do Themów #12

Open
pplotka opened this issue Feb 4, 2021 · 2 comments
Open

Przełączenie się na Webpacka, przeniesienie szablonów admina do Themów #12

pplotka opened this issue Feb 4, 2021 · 2 comments
Assignees
@pplotka
Labels
topic-proposal

Comments

@pplotka
Copy link
Owner

pplotka commented Feb 4, 2021

No description provided.

@pplotka pplotka self-assigned this Feb 4, 2021
@pplotka
Copy link
Owner Author

pplotka commented Feb 9, 2021

  1. Custom ThemeContext.
  2. Drawbacks:
    a) not a common structure
    b) for a larger project (we have ADR documented this change and a separate section about upgrade sylius for our system)
  3. Pros:
    a) cleaner top directory
    b) we can remove templates
    c) everything related to templates/themes is in one directory

@pplotka
Copy link
Owner Author

pplotka commented Feb 25, 2021

MRy Sylius introducted Webpack:

Bye, bye Gulp: Sylius/Sylius#12043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pplotka pplotka

Labels
topic-proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pplotka