Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug report: cannot disable "Follow" button in the profile widget #808

Closed
developomp opened this issue Nov 2, 2020 · 0 comments
Closed

Bug report: cannot disable "Follow" button in the profile widget #808

developomp opened this issue Nov 2, 2020 · 0 comments
Labels
bug:extension Issues about widgets, comment, share, search, and plugins.

Comments

@developomp
Copy link

Describe the bug
The Follow button (red circle) cannot be removed by commenting out the widgets.gravatar.follow_link field in the _config.icarus.yml config file.

This is because url_for(follow_link) in layout/widget/profile.jsx returns / instead of undefined when there's no follow_link. This / is recognized as a valid url and activates the Follow button.

To Reproduce

  1. comment out widgets.gravatar.follow_link field in the _config.icarus.yml config file.
  2. hexo generate
  3. The follow link isn't removed

Screenshots
disclaimer: using ss from your website instead of mine
this
@ppoffice ppoffice added the bug:extension Issues about widgets, comment, share, search, and plugins. label Nov 2, 2020
ppoffice referenced this issue Nov 3, 2020
@ppoffice
fix(widget): hide follow button for empty follow link
75dc226
@ppoffice ppoffice closed this as completed Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:extension Issues about widgets, comment, share, search, and plugins.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ppoffice @developomp