Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null value shows first time #3

Closed
pprathameshmore opened this issue Oct 4, 2019 · 12 comments
Closed

Null value shows first time #3

pprathameshmore opened this issue Oct 4, 2019 · 12 comments
Assignees
Labels
hacktoberfest Make your contribution help wanted Extra attention is needed

Comments

@pprathameshmore
Copy link
Owner

When you first time install this extension, there is "What is your main focus for today?" text below shows the "null" text. We have to show as "Click here to add"

@pprathameshmore pprathameshmore added help wanted Extra attention is needed hacktoberfest Make your contribution labels Oct 4, 2019
@rowhitswami
Copy link
Contributor

I'd like to take this up

@pprathameshmore
Copy link
Owner Author

@rowhitswami Yeah! Go ahead!

@rowhitswami
Copy link
Contributor

Thank you @pprathameshmore
Can you help me with setting up this project on my local machine? How can I test it on my machine?

@pprathameshmore
Copy link
Owner Author

Yeah!

  1. Just clone it on your machine.
  2. Go to Chrome->Setting->More tools->Extension
  3. Turn developer mode on
  4. Select Load unpacked
  5. Select cloned folder
  6. Now Chrome Extension is installed in your Chrome.

Now make changes in code and reload that same extension from Chrome to see changes in the browser.

Annotation 2019-10-04 172818

@rowhitswami
Copy link
Contributor

Oh thank you so much but I figured it out and now I'm done with the code.
Raising PR in a few minutes. 😊

@pprathameshmore
Copy link
Owner Author

pprathameshmore commented Oct 4, 2019

We have to show as "Click here to add" when there is a null value

@rowhitswami
Copy link
Contributor

Okay great. Let me work on it.
BTW found another bug. Creating an issue for the same.

@pprathameshmore
Copy link
Owner Author

Yeah! @rowhitswami

@pprathameshmore
Copy link
Owner Author

Did you see that there is a null value when you first time installed this extension? @rowhitswami

@rowhitswami
Copy link
Contributor

Yeah, that's probably because it is creating p element but has no content to show in it. So I added a condition to check if it has a value or not.

@pprathameshmore
Copy link
Owner Author

Yeah! If there is no value then we have to show "Click here to add" message in p element.

@pprathameshmore
Copy link
Owner Author

@rowhitswami I never tested your PR at locally. Is that working properly so I can merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Make your contribution help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants