Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query, key, and value are different from the paper #5

Open
coolbay opened this issue Apr 3, 2021 · 0 comments
Open

Query, key, and value are different from the paper #5

coolbay opened this issue Apr 3, 2021 · 0 comments

Comments

@coolbay
Copy link

coolbay commented Apr 3, 2021

Hi!

In the paper, it mentions that the query is an ROI, and key and values are from the clip around an ROI. But in this implementation, it seems that all query, key and value are from the features in the same spatial locations. In that case, it will not be able to aggregate another person that the target person is talking to.

Please clarify this I am mistaken. Thank you very much!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@coolbay