New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iphone x max and XR support #12

Merged

ppth0608 merged 2 commits into ppth0608:master from logansease:master

Apr 8, 2019

Contributor

logansease commented Apr 7, 2019

this PR addresses several issues for iphone max and xr

adds new screen sizes to the notch check
uses a check to look at the safe area inset size to determine notch existence
explicitly position message at bottom of the status bar

Also

fixes the nav bar message to handle a tab bar controller in the root
increases font weight to medium for better visibility

logansease added 2 commits

April 7, 2019 17:27


          support for iphone x max and xr

7bf4eb0


          support a tab bar for nav bar alerts

8760edf

Owner

ppth0608 commented Apr 8, 2019

@logansease LGTM :) Thank you for contribution.

ppth0608 merged commit 63beeaa into ppth0608:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment