Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize For with predicate #8

Open
BEagle1984 opened this issue Jul 18, 2019 · 1 comment
Open

Optimize For with predicate #8

BEagle1984 opened this issue Jul 18, 2019 · 1 comment
Labels
good first issue Good for newcomers

Comments

@BEagle1984
Copy link

I know it's not super easy but I'd expect the predicate to be passed in the update statement instead of executing a query just to load the primary keys.
Plus I wouldn't rely on EF but use a raw sql, aiming at getting rid of the dependency to EF.

@ppx80
Copy link
Owner

ppx80 commented Jul 19, 2019

Hi @BEagle1984, thanks for the suggestion.
I'm working on a method (named Where) that should be doing exactly what you described.
I use EF because it allows me to generate the query starting from the given entity. Starting with SqlConnection forces me to re-engineer everything ..... But I can think about it.

@ppx80 ppx80 added the good first issue Good for newcomers label Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants