Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit conversions in SRGBColour should not exist #5714

Open
frenzibyte opened this issue Mar 28, 2023 · 0 comments
Open

Implicit conversions in SRGBColour should not exist #5714

frenzibyte opened this issue Mar 28, 2023 · 0 comments

Comments

@frenzibyte
Copy link
Member

As part of making sense of sRGB colours. It should be explicitly shown whether SRGBColour is going to give a linear or sRGB colour, by getting rid of the implicit conversions in SRGBColour and potentially replacing them in public API with just pure Colour4s.

This should make it clear in what space the colours passed to the shader are, and hopefully reduce confusion on sRGB colours in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant