Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown<T>.GenerateItemText flow needs reassessment #5851

Open
frenzibyte opened this issue Jun 19, 2023 · 0 comments
Open

Dropdown<T>.GenerateItemText flow needs reassessment #5851

frenzibyte opened this issue Jun 19, 2023 · 0 comments

Comments

@frenzibyte
Copy link
Member

Recently, a series of pull requests got opened and merged back and fourth to resolve edge cases all revolving around GenerateItemText:

While GenerateItemText might behave more properly right now, I believe going forward, the best place I can imagine for calling GenerateItemText would be somewhere within the DrawableMenuItem itself when the item label is actually needed for display.

That way would guarantee both the Dropdown's BDL to be called first, and guarantee the label assignment happening while the drawable menu item is loading (rather than after it's loaded, potentially causing a performance hit or wrong one-frame display). All without going through checking load states or scheduling anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant