Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IncrementalBSplineBuilder fails to add control points at start of input path #6046

Closed
OliBomby opened this issue Nov 13, 2023 · 0 comments · Fixed by #6047
Closed

IncrementalBSplineBuilder fails to add control points at start of input path #6046

OliBomby opened this issue Nov 13, 2023 · 0 comments · Fixed by #6047

Comments

@OliBomby
Copy link
Contributor

Best explained using TestSceneInteractivePathDrawing. If you draw a path, the B-spline builder will not start adding control points until a certain distance from the starting point is reached, so any detail at the start of the input path is lost.

osu.Framework.Tests_G9BaX2XKTU.mp4

I think the issue is on IncrementalBSplineBuilder line 159.
In this scenario, the control point count is 2 so momentum direction does not get calculated. Therefore only the distance is taken into account to determine whether to add a new control point.
A fix could be to take the momentum direction from the start of the input path as the momentum direction for the control points if the control point count is 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant