-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tried to change hp drain of taiko beatmap, instead it (appeared to have) deleted all the hit objects #28041
Comments
Did you rename the difficulty as part of the save that deleted everything? Struggling to find a quick and plausible explanation how this can happen otherwise. |
Unfortunately no, I had renamed it beforehand. The only change was to the HP drain. |
I guess you could but if it's just blank I dunno how much that's gonna do. Better than nothing though. |
Ooh now this is interesting. I exported the osz, and to test if it's really empty I imported it on an osu install on another computer. But when I imported it, all the notes were there! This worked on both lazer and stable. So, it still looks empty on the original computer's lazer install, but if I export and import it, it gets its notes back and has the updated hp drain setting. Maybe it hasn't deleted the notes, it just thinks that they're not there for some reason. Here is the export: |
That's interesting... I suppose you've already overwritten the version of the map that was empty? If you haven't then a |
No worries, I haven't touched the empty map yet. Here you go |
Well I can sort of see what happened to break it, but I'm not sure how it happened. These are the hashes of the beatmap files in the database where the beatmap has gone missing: And these are the hashes of the beatmap files in the export:
The only files that are matching are:
The rest isn't matching. So I'd expect every single difficulty in this mapset other than that one to be broken. If I import the actual online map and re-export via lazer, I get:
which probably explains the online diffs mismatching (the exporter doesn't just move the files out, it re-encodes them, and the re-encode isn't going to be byte-for-byte, hence the changing SHAs). But it doesn't explain why the edited difficulties' hashes desynced. In log I also see this:
which makes me suspicious (why is I'm half hoping this could be something that is fixed by #27997 but that may well be wishful thinking @villuna Are you able to describe in more detail how these difficulties were created? In which order? Were they created one after another during one lazer session? When and how were they renamed? |
Sure, they were made one after another in the same lazer session, like you said. I'm not sure I remember 100%, but i'm pretty sure i made my top difficulty first, then when that was finished i made my Oni. I think at that point was when i renamed the top diff to 'villuna's Objection!', just using the editor. Then I created the new difficulty but exited without doing anything with it. Finally, i changed the health drain settings and ran into the issue. Although, the fact that there are two "New Difficulty" beatmaps gives me a thought. My mouse has an occasional double-clicking problem. The LMB switch sometimes triggers twice, so fast that there's almost no time at all between the two presses. I don't remember making two new difficulties but i wonder if my mouse clicked "make new difficulty/osu!taiko" twice really really quickly. That's just a guess though, i dont even know if thats possible. |
I've tried a few things but I can't make this happen. If you are able to somehow pinpoint how this can happen then it would be appreciated. At this stage I'm mostly just crossing my fingers that the aforementioned fix will have gotten this too... |
I have used Lazer to make some beatmap modifications before, and I remember that this problem did not occur when exporting the beatmap to stable for uploading.
catbox It is worth noting that I specially modified easy that adjusted HP and OD, but I completed and uploaded it in stable and uploaded. |
Type
Game behaviour
Bug description
I was editing a local beatmap that I had made on an existing beatmap set, and I had added two extra difficulties and went to change the hp drain. I did nothing but enter the editor, change the setting and exit the editor again, and for my highest difficulty it honest to god deleted all of the hit objects and reverted it to default hp drain (but kept the other stats the same). Interestingly the second highest difficulty was totally fine.
At the time, I had an empty difficulty in the set which I hadn't done anything with, so that could have also had an effect.
I've attached logs but note that after this happened I restarted osu once in a panicked attempt to see if that would fix it (it did not), so the most recent logs probably aren't relevant.
I couldn't get a video of it happening unfortunately but I've attached a screenshot of the beatmap set before (the diff had a different name and I hadn't made the other one) and after the incident. Not sure it'll be of much help but I had the screenshots on hand
Screenshots or videos
Version
2024.412.1
Logs
compressed-logs.zip
The text was updated successfully, but these errors were encountered: