Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dilithium/ref/poly.c:868 maybe not correct? #63

Open
ffox9527 opened this issue Jul 25, 2022 · 1 comment
Open

dilithium/ref/poly.c:868 maybe not correct? #63

ffox9527 opened this issue Jul 25, 2022 · 1 comment

Comments

@ffox9527
Copy link

now is
r->coeffs[2*i+0] &= 0xFFFFF;
maybe
r->coeffs[2*i+1] &= 0xFFFFF;
not sure, pls check, thx!
@ffox9527
Copy link
Author

The line should be superfluous, r->coeffs[2i+0] has been AND with 0xFFFFF, and r->coeffs[2i+1] only has 20 bits, no need to AND with 0xFFFFF.

@thomwiggers thomwiggers mentioned this issue Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ffox9527