Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of bound check in NTT/INTT #71

Closed
SherifElewaa opened this issue Mar 2, 2024 · 2 comments
Closed

Out of bound check in NTT/INTT #71

SherifElewaa opened this issue Mar 2, 2024 · 2 comments

Comments

@SherifElewaa
Copy link

Dear gregorseiler,

In ntt.c source code, there is out-of-boundary check inside ntt and intt functions. For example, in ntt function in line #68 integer j used in the for loop is defined but not initialized:

for(start = 0; start < 256; start = j + len)

As a result, this causes r[j + len] to go out-of-boundary somehow. Could you please comment on this?

Thanks,
Sherif

@cryptojedi
Copy link
Contributor

The statement start = j + len is executed at the end of the for-loop body
and by that time, the variable j is initialized.

@SherifElewaa
Copy link
Author

OK, I see. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants