Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging a string changes it's value slightly #11

Closed
devoncarew opened this issue Sep 27, 2018 · 2 comments
Closed

logging a string changes it's value slightly #11

devoncarew opened this issue Sep 27, 2018 · 2 comments

Comments

@devoncarew
Copy link
Contributor

Right now, the api converts all logged objects into their jsonable equivalent. So, log('foo_channel', () => 'My message') will convert that string param into its jsonable equivalent (which is "My message").

We then essentially get "My message" in the client instead of My message.
@pq
Copy link
Owner

pq commented Sep 30, 2018

I agree this is unexpected. I think the approach in #19 should tackle it.

@pq
Copy link
Owner

pq commented Oct 2, 2018

Fixed w/ #19.

@pq pq closed this as completed Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pq @devoncarew