You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mlkem-common.c: _gcry_mlkem_mlkem_shake256_rkprf:
gcry_md_hash_buffers_extract can be used here instead of _gcry_md_open&write&extract&close.
mlkem-symmetric.c: _gcry_mlkem_shake256_prf:
_gcry_md_hash_buffers_extract can be used here instead of _gcry_md_open&write&extract&close. Temporary buffer > usage can be avoided by passing input buffers through two IOV to _gcry_md_hash_buffers_extract.
The text was updated successfully, but these errors were encountered:
in the code of _gcry_md_hash_buffers_extract it says:
The only supported flag in FLAGS is GCRY_MD_FLAG_HMAC which turns this function into a HMAC function; the first item in IOV is then used as the key."
The flag GCRY_MD_FLAG_SECURE that we need is thus not supported. Also I don't see much saving in code lines, as also the buffer object would have to be initialized.
This is the code I used to test it which gave a runtime error (Invalid Argument):
falko-strenzke
changed the title
_gcry_md_hash_buffers_extract can be used here instead of _gcry_md_open&write&extract&close.
_gcry_md_hash_buffers_extract can be used instead of _gcry_md_open&write&extract&close.
Oct 17, 2023
from Jussi's review
The text was updated successfully, but these errors were encountered: