apns-push-type cannot be present with voip push

[matthewh]

I'm getting InvalidPushType when attempting to send a VOIP push with apns-push-type specified.

[eliburke]

This started failing on Sept 19th for us, the day iOS 13 was released (literally, working in the afternoon on the 18th, failing in the morning on the 19th). apns-push-type cannot be set to alert or to background or it reports an error and is not delivered to clients.

We did not test it with other values, but with a forked copy of PyAPNs2 that does not set apns-push-type our VOIP push notifications started working again.

[Pr0Ger]

Looks like Apple recently added few new types of notifications (voip, complication, fileprovider, mdm) and also lifted requirement that this field is required (now it is only required for notifications for watchOS 6). I'll release an update to reflect this changes tonight

[72squared]

Seems like you should also handle the InvalidPushType response here?

https://github.com/Pr0Ger/PyAPNs2/blob/master/apns2/errors.py#L170-L200