Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem with rules is that it is impossible to figure out if rules have actually been changed between builds and because rules have been a part of field data it was considered as a change for that field.
This allowed to easily get into an infinite rendering loop.
This PR will separate field rules from field data, thus providing the ability to prevent unnecessary build triggers and ignore rules changes since those are not actually needed for rendering and are not really a part of the state either.
Updating rules by programmatically on SuperForm instance never made much sense for fields that have their widgets so there is no need to implement listening on that. If there would be a need for that it would probably be exposed via
onRulesChange
callback similar toonChange
Consider this bug fix as a minor breaking change.
Type of Change