Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image not showing up #101

Closed
phoenixthefirebird opened this issue Feb 23, 2021 · 6 comments
Closed

Image not showing up #101

phoenixthefirebird opened this issue Feb 23, 2021 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@phoenixthefirebird
Copy link

Describe the bug
Despite following the instruction in README closely, images I link in the media attributes are not showing up in the timeline element at all. Below is how my code looks like.

        title: "May 1940",
        cardTitle: "Project 1",
        cardSubtitle:"Description of my amazing project",
        cardDetailedText: "Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.",
        media: {
          source: {
            url: "https://cdn.the-scientist.com/assets/articleNo/66820/hImg/34886/bird-banner3-l.png",
            type:"png"
          },
          type: "IMAGE"
        }
      },

Expected behavior
Image shows up in the timeline card

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome

Thanks in advance!

@prabhuignoto prabhuignoto self-assigned this Feb 23, 2021
@prabhuignoto prabhuignoto added the bug Something isn't working label Feb 23, 2021
@prabhuignoto
Copy link
Owner

@phoenixthefirebird Thanks for reporting the issue. Can you point me to the repo to replicate this issue

@phoenixthefirebird
Copy link
Author

Thank you for your quick reply! Below is the link and I'm using the timeline as the project part of my portfolio. please let me know if you can figure out what's wrong!

https://github.com/phoenixthefirebird/phoenixthefirebird.github.io.git

@prabhuignoto
Copy link
Owner

prabhuignoto commented Feb 24, 2021

@phoenixthefirebird
I figured the cardHeight prop is not getting set for the cards in vertical mode. can you manually pass the prop like below for the time being.

<Chrono cardHeight={200} />

this will be fixed in the next patch release where you don't need to manually pass this prop. can you check and let me know if this worked for you.

@phoenixthefirebird
Copy link
Author

It works now and the timeline looks great, thank you so much!

@prabhuignoto
Copy link
Owner

@phoenixthefirebird
glad it worked. i checked your site, the timelines would look better if its wrapped inside a container.

@phoenixthefirebird
Copy link
Author

Thank you for the feedback will try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants