Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help: Adding menu items with custom properties #10

Closed
farrukhsubhani opened this issue Nov 29, 2020 · 2 comments · Fixed by #12 or #15
Closed

Help: Adding menu items with custom properties #10

farrukhsubhani opened this issue Nov 29, 2020 · 2 comments · Fixed by #12 or #15
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@farrukhsubhani
Copy link

You are planning to have icons in menu. I assume this would a property on each item to define an icon or not.

Can we have other custom properties on menu like hidden or a function to define its visibility url to be used when item is passed on selected function with those properties.

This functionality might already be there and if it is it would be good to have an example of some common scenarios like:

  1. Attach a url to menu item and set it to open in new tab or window

  2. Hide certain menu items or disable them from being selected.

Thanks a lot for such a nice component.

@prabhuignoto prabhuignoto self-assigned this Nov 29, 2020
@prabhuignoto prabhuignoto added enhancement New feature or request good first issue Good for newcomers labels Nov 29, 2020
@prabhuignoto
Copy link
Owner

prabhuignoto commented Nov 30, 2020

You are planning to have icons in menu. I assume this would a property on each item to define an icon or not.

yes this would be a new property on each item. This should be available in the next major release.

Can we have other custom properties on menu like hidden or a function to define its visibility url to be used when item is passed on selected function with those properties.

there is already a property disable to disable items on the menu. could you give it a try. Thanks for reporting as this is missing from the documentation. i will update the doc.

  1. Attach a url to menu item and set it to open in new tab or window

i am just wondering how often people would use this as a feature and this could be easily managed from the selection handler.

thanks

@prabhuignoto prabhuignoto linked a pull request Dec 1, 2020 that will close this issue
@prabhuignoto prabhuignoto linked a pull request Dec 11, 2020 that will close this issue
@prabhuignoto
Copy link
Owner

@farrukhsubhani the component now has full support for icons. After some pondering, I decided to use slots as this will give better flexibility.

please check out the usage here.
https://github.com/prabhuignoto/vue-dock-menu#-icon-support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
2 participants