New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Snyk] Security upgrade sequelize from 6.19.0 to 6.21.2 #188
Conversation
…e-templates/services/order-service/package-lock.json to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-SEQUELIZE-2959225
Codecov Report
@@ Coverage Diff @@
## main #188 +/- ##
=======================================
Coverage 89.91% 89.91%
=======================================
Files 14 14
Lines 456 456
Branches 40 40
=======================================
Hits 410 410
Misses 45 45
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
I got asked that recently too and was thinking about integrating a workflow that automerges. Seems that you'd be in favor of that happening. Not everyone has tests, and some developers I assume might still want to vet what changes were exactly introduced. I've heard of developers going through the changelog and READMEs of updated packages. |
@mikicho Isn't it better to let Snyk act as an app instead of impersonation (real user token)? |
@goldbergyoni I'd love to. |
What's the actual ask? |
@lirantal is it possible to open the PR on behalf of snyk app instead of my user name? |
Ahh I see. This is somewhat explained here but here's how to fix it. |
@mikicho In the article that Liran provided: "For public repositories, the fix PR will be opened by Snyk-bot" Should be a place in Snyk's config to set this |
@goldbergyoni I couldn't find this option. You are also to org owner in Snyk if you want to take a look |
This PR was automatically created by Snyk using the credentials of a real user.
Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR
Vulnerabilities that will be fixed
With an upgrade:
Why? Recently disclosed, Has a fix available, CVSS 7
SNYK-JS-SEQUELIZE-2959225
(*) Note that the real score may have changed since the PR was raised.
Commit messages
Package name: sequelize
The new version differs by 11 commits.See the full diff
Check the changes in this PR to ensure they won't cause issues with your project.
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 SQL Injection