Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show CLI spinner while we generate the code #83

Open
goldbergyoni opened this issue May 3, 2022 · 3 comments
Open

Show CLI spinner while we generate the code #83

goldbergyoni opened this issue May 3, 2022 · 3 comments
Labels
3-hours-or-less enhancement New feature or request good first issue Good for newcomers non-blocking You may claim this and process slowly over time, it doesn't the critical path

Comments

@goldbergyoni
Copy link
Contributor

馃幆 Goal: - When the non-interactive CLI command is invoked, we should show some friendly spinner and message until the code is generated. When it's ready, it could be nice to show some nice message like "All set, the code is ready for you with tons of good practices inside"

Here is how our UI looks like (no emoji, no text):
image

Try it yourself with this command:

npx @practica/create-node-app immediate

Here how cool it could be (taken from nx UI):

image

馃 Things to consider:

  • There are plenty of tools that can achieve this easily like this one
  • It should be done in the code under ~/src/code-generator/entry-points/non-interactive-cli.tsx. You may just await on the main function that generates code, while we await we can show spinner and then a success message
  • Optional bonus: Run E2E to ensure it's there
@goldbergyoni goldbergyoni added enhancement New feature or request good first issue Good for newcomers 3-hours-or-less coding non-blocking You may claim this and process slowly over time, it doesn't the critical path and removed coding labels May 3, 2022
@AvivMoyalAutodesk
Copy link

took the issue

@goldbergyoni
Copy link
Contributor Author

@AvivMoyalAutodesk Still on it?

@marcosmol204
Copy link
Contributor

Opened PR #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3-hours-or-less enhancement New feature or request good first issue Good for newcomers non-blocking You may claim this and process slowly over time, it doesn't the critical path
Projects
None yet
Development

No branches or pull requests

3 participants